Mobile popup improvement#1096
Open
JasonNguyen067 wants to merge 9 commits intomainfrom
Open
Conversation
JasonNguyen067
temporarily deployed
to
staging-1096
GitHub Actions
Inactive
JasonNguyen067
temporarily deployed
to
staging-1096
GitHub Actions
Inactive
CadenLee2
reviewed
Apr 28, 2026
Collaborator
CadenLee2
left a comment
CadenLee2
left a comment
There was a problem hiding this comment.
When discussing in our meeting, the reasoning for changing the height of the mobile popup was to make it clear that it's a popup rather than some bug with the top bar. As such I think it might be more natural to have it slightly less tall to look more natural/independent from the top bar (see screenshot for an idea), but lmk what you think
JasonNguyen067
temporarily deployed
to
staging-1096
GitHub Actions
Inactive
JasonNguyen067
temporarily deployed
to
staging-1096
GitHub Actions
Inactive
CadenLee2
reviewed
May 3, 2026
Collaborator
CadenLee2
left a comment
CadenLee2
left a comment
There was a problem hiding this comment.
There are still some weird visual interactions, I think fixing these will boil down to fixing just a few details in the logic when it comes to borders/edge cases.
See the three I noticed here:
- When partway scrolled down, the cancel button gets offset weirdly if you try to collapse the menu from above
- When partway scrolled down, the menu glitches when you try to scroll back up and reach the top
2026-05-03.10-03-54.mp4
- When you try to collapse the menu from above then change your mind and move your finger back up, the collapsing fails
https://github.com/user-attachments/assets/fa671f27-aebe-4c99-80be-008b5c3ca0fa
JasonNguyen067
temporarily deployed
to
staging-1096
GitHub Actions
Inactive
JasonNguyen067
temporarily deployed
to
staging-1096
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Decreased height of the pop-up. Updated border radius of the popup, fixed scroll logic, and added a swipe down animation to close the popup.
Screenshots
Before:
After:
Test Plan
Click on add course, verify that it's the correct height with border radius, try scrolling to see just the pop-up scrolling and not the background and swipe down on the pop-up to see if it closes.
Issues
Closes #1076